YellowGrass

Cache/skip wikitext rendering during isNullAutoBox check (1)

Something to investigate, as processing of WikiText is resource-intensive.

Submitted by Elmer van Chastelet on 23 May 2013 at 15:45

Issue Log

On 23 May 2013 at 15:45 Elmer van Chastelet tagged performance
On 23 May 2013 at 15:48 Eelco Visser commented:

+1

On 24 May 2013 at 12:57 Christoffer Gersen commented:

By looking at the outputWikiText_Template.java file from precompile-build-ins this already seems to be the case. However, the WikiFormatter is executed twice within renderInternal, because of a isNullAutoBox check.

On 28 May 2013 at 15:28 Elmer van Chastelet tagged !eelcovisser
On 28 May 2013 at 15:28 Elmer van Chastelet removed tag improvement
On 28 May 2013 at 15:28 Elmer van Chastelet removed tag !eelcovisser
On 28 May 2013 at 15:28 Elmer van Chastelet tagged !eelcovisser
On 28 May 2013 at 15:28 Elmer van Chastelet removed tag !eelcovisser
On 28 May 2013 at 15:28 Elmer van Chastelet tagged !elmer
On 28 May 2013 at 15:28 Elmer van Chastelet tagged !eelcovisser
On 28 May 2013 at 15:28 Elmer van Chastelet removed tag !eelcovisser
On 28 May 2013 at 15:33 Elmer van Chastelet commented:

Sorry for the assignment tag events, see https://yellowgrass.org/issue/YellowGrass/364

On 28 May 2013 at 18:20 Elmer van Chastelet commented:

Fixed r5716

This was a very easy performance gaining change. A quick test reveals memory footprint for a single request on page with large wikitext dropped from +/- 32MB to 21MB.
Page load time dropped from 98ms to 55ms avg.

On 28 May 2013 at 18:20 Elmer van Chastelet closed this issue.

Log in to post comments