Resolving markers are whitespace sensitive
For example the test:
test variable usage [[ int32 [[x]] = 1; int32 y = [[x]] + 1; ]] resolve #2 to #1
Succeeds, but if you use
[[ x ]]
instead (with spaces around thex
), the marker cannot be resolved.I believe it’s because this https://github.com/metaborg/spt/blob/new-spoofax-plugin/org.metaborg.meta.lang.spt/editor/java/org/metaborg/meta/lang/spt/strategies/SelectionFetcher.java#L101-L103 condition matches the exact offset. For example the
Matches
starts at location 159, but the AST term starts at 160.I believe the whitespace was ignored in spoofax 1.4. Naively ignoring the layout is probably not what you want, as some languages have significant whitespace.
Submitted by Arian on 12 January 2016 at 10:23Eclipse: org.eclipse.epp.package.standard.feature.feature.group 4.4.2.20150219-0708
Spoofax: org.metaborg.spoofax.eclipse 1.5.0.20151125-144048-new-spoofax-plugin
System: Linux amd64 3.13.0-68-generic
Issue Log
Log in to post comments