YellowGrass

Use the language plugin's class loader to load all its jar files (3)

See the TODO in StrategoObserver.java. Doing so currently seems to cause Spoofax/321. It may well be that the current approach, introduced in r21475 (now commented out), only works before a plugin is actually deployed.

Submitted by Lennart Kats on 14 December 2010 at 15:06

Issue Log

On 14 December 2010 at 15:14 Lennart Kats tagged @lennartkats
On 14 December 2010 at 15:14 Lennart Kats tagged @dannygroenewegen
On 14 December 2010 at 15:14 Lennart Kats tagged @nathanbruning
On 14 December 2010 at 15:14 Lennart Kats commented:

It would be helpful to know if this bug, that appears in 0.6.0.1, also occurs with a source version of the webdsl plugin. That would tell us if it’s a problem specific to the plugin configuration of the webdsl plugin, or if it is actually a problem with deployed plugins.

On 14 December 2010 at 15:15 Lennart Kats tagged !robvermaas
On 14 December 2010 at 15:23 Lennart Kats tagged 1.0
On 15 December 2010 at 14:19 Lennart Kats commented:

Sander confirmed that indeed this problem only occurs with the deployed webdsl plugin, not with the plugin in source form. So it is a post-deployment issue, and it may or may not be specific to webdsl (likely not).

On 23 November 2011 at 17:59 Lennart Kats tagged 1.1
On 23 November 2011 at 17:59 Lennart Kats removed tag 1.0
On 23 November 2011 at 17:59 Lennart Kats tagged !karltk
On 25 April 2012 at 09:38 Oskar van Rest tagged !oskarvanrest
On 11 May 2012 at 10:59 Oskar van Rest tagged @oskarvanrest
On 11 May 2012 at 11:02 Oskar van Rest closed this issue.
On 11 May 2012 at 11:02 Oskar van Rest commented:

fixed in revision r24813+r24820
also see Spoofax/522

On 24 July 2013 at 00:56 Oskar van Rest reopened this issue.
On 24 July 2013 at 00:58 Oskar van Rest commented:

So I didn’t realize until now that buddy class loading doesn’t solve the problem in case you build to jar rather than ctree. I’m going to try to combine our solutions and hopefully solve this problem for good.

On 24 July 2013 at 01:00 Oskar van Rest removed tag 1.1
On 24 July 2013 at 01:01 Oskar van Rest tagged 1.2
On 24 July 2013 at 23:08 Oskar van Rest commented:

This fixed it: https://github.com/metaborg/spoofax/commit/1dbb44624e789f5b1d7154aedc3c3576fdf403fa
Now everything works before/after deployment with jar/ctree.

Note: this extra code is only needed for Java compilation and does not affect the result of the build. We still rely on buddy class loading during runtime.
It’s a bit of a hack so if you have a better idea then let me know.

There’s one special case you should be aware of, which is if you want to use a plug-in that is not installed in Eclipse but is located in your workspace instead.
For testing purposes, you’ll need to run a second Eclipse instance or you’ll get ClassNotFoundExceptions. In addition, if you’re building to jar, you’ll need to make a jar of your plug-in and put it in eclipse.home/plugins/ or put it on the classpath in some other way.

On 24 July 2013 at 23:08 Oskar van Rest closed this issue.

Log in to post comments