Dodgy external js silently breaks release build
This code is enough to break the release build:
application ReleaseTest import mobl::ui::generic load jquery.flot.js // remove this and release build works screen root() { header("Release build test") }
www.release gets created, but the js file is not compressed and does not contain any mobl-lib code.
The development release works as expected.
Replace jquery.flot.js with a trivial foo.js file containing var j=1; and the build works.
jquery.flot.js generates 50 jslint warnings. Fix these and the build works.
However, fixing jslint warnings is not at all easy - jquery.flot.js contains some minimised code that has missing semicolons. It would be much better to if the build process were more robust - possibly by excluding external js from compression by mobl?
Mike
Submitted by Mike Pearson on 2 June 2011 at 18:44
Issue Log
By interval halving, I narrowed the problem to just one line in jquery.flot.js release 0.7.
It’s line 1560 - a continue statement with a missing semi-colon,:
L1559 if (!axis.show || axis.ticks.length == 0) L1560 continue
Hopefully this will be solved by this: https://yellowgrass.org/issue/mobl/238
Log in to post comments