YellowGrass

Comments are not indexed for full-text search

The “search” button doesn’t find issues that contain the search terms in the comments. E.g. a search for “cgroup” should show https://yellowgrass.org/issue/Nix/219.

Submitted by Eelco Dolstra on 8 June 2011 at 17:04

Issue Log

On 8 June 2011 at 17:22 Sander Vermolen tagged 1.14
On 3 August 2011 at 13:34 Sander Vermolen removed tag 1.14
On 3 August 2011 at 13:34 Sander Vermolen tagged 1.20
On 23 August 2011 at 16:54 Sander Vermolen removed tag 1.20
On 23 August 2011 at 16:54 Sander Vermolen tagged 1.30
On 25 August 2011 at 10:14 Sander Vermolen commented:

We are fixing the other search problems now as well. So I’ll fix this one a bit sooner too. Assigning it to the upcoming release.

On 25 August 2011 at 10:14 Sander Vermolen tagged 1.22
On 25 August 2011 at 10:14 Sander Vermolen removed tag 1.30
On 8 February 2012 at 15:59 chris melman commented:

the problem is to fix this we have to set an inverse property which could delete every comment/issue

On 12 February 2012 at 16:09 Sander Vermolen commented:

Why do you need an inverse relation? Setting an inverse on (a new) Comment.issue to Issue.log would not work, as log may also contain other events, besides, this would not aid the search, right?

Instead, we introduced the (searchable(name=comments, subclass=Comment)) annotation on Issue.log to make search find issues based on comment text. Does that not work?

On 12 February 2012 at 23:12 chris melman commented:

indeed this(searchable(name=comments, subclass=Comment)) annotation, only seems to work when the property has an inverse anotation as well.

On 19 February 2012 at 09:03 Sander Vermolen commented:

But setting a regular inverse in Comment is not possible. Wasn’t that the whole idea of the ‘subclass’ command? A log does not just contain comments, but any type of events. Setting an inverse in event (to Issue.log) would be fine, but setting one in Comment would only make sense if it would somehow be a ‘combined inverse’ with the other types of events (e.g. TagAddition and TagRemoval). I do not know the exact semantics of a Hibernate inverse, perhaps I got it wrong, but an inverse in Comment certainly cannot functionally invert the event log.

On 29 December 2012 at 19:40 Eelco Visser removed tag 1.22
On 29 December 2012 at 19:40 Eelco Visser tagged 1.30
On 29 December 2012 at 19:41 Eelco Visser removed tag 1.30
On 2 January 2013 at 19:13 Eelco Visser tagged 1.60
On 2 January 2013 at 19:13 Eelco Visser tagged @elmer
On 8 January 2013 at 15:53 Elmer van Chastelet commented:

Issues are now searchable on comments and more

  • Issues can be searched on:
  • title
  • description
  • tag (new)
  • reporter name
  • comments (new)
  • Changed searchable annos into search mapping for Issue
On 8 January 2013 at 15:53 Elmer van Chastelet closed this issue.

Log in to post comments